feat: add inline hooks quota support by wangsijie · Pull Request #9078 · logto-io/logto

wangsijie · 2026-06-23T11:52:30Z

Summary

Completes Logto-side support for the inlineHooksEnabled subscription quota key.

This PR keeps inlineHooksEnabled on the boolean feature-quota path: Core and Console treat older Cloud responses as false when the key is absent, Console includes the key in subscription usage/quota types, and the default Console development SKU keeps inline hooks disabled. The rollout plan is still selected-enterprise-only: only selected enterprise SKUs should be manually enabled, and everyone else stays disabled.

The SKU quota item is intentionally hidden from the Console plan quota UI for now, with an inline comment noting that it should wait until further testing before being opened.

It is intentionally not added to add-on/reportable usage reporting.

Cloud companion PR: logto-io/cloud#1956.

Testing

Tested locally

Note

Medium Risk
Touches subscription typing and quota normalization used for entitlements; behavior stays opt-in (default false) but incorrect defaults could affect feature gating when Cloud enables the flag.

Overview
Adds inlineHooksEnabled as a boolean subscription quota across Console and Core, aligned with an updated @logto/cloud package.

Core extends subscription quota/usage types and tenant-usage guards, defaults missing Cloud values to false in getTenantSubscription, and includes the flag in the Redis subscription cache schema. It is not added to reportable item-updates usage keys.

Console merges API quota/usage with defaults via normalizeSubscriptionQuota / normalizeSubscriptionUsage, sets inlineHooksEnabled: false on default SKUs, and keeps the quota out of plan UI (hidden downgrade diff, excluded phrase maps, filtered in upgrade/downgrade modals) until further testing.

Also bumps default dev SKU fields for samlApplicationsLimit and customDomainsLimit in tenant constants.

^{Reviewed by Cursor Bugbot for commit 6e5e585. Bugbot is set up for automated code reviews on this repo. Configure here.}

github-actions · 2026-06-23T11:52:50Z

COMPARE TO `master`

Total Size Diff 📈 +1.82 KB

Diff by File

Name	Diff
packages/console/package.json	0 Bytes
packages/console/src/cloud/types/router.ts	📈 +290 Bytes
packages/console/src/consts/plan-quotas.ts	📈 +126 Bytes
packages/console/src/consts/quota-item-phrases.ts	📈 +222 Bytes
packages/console/src/consts/tenants.ts	📈 +146 Bytes
packages/console/src/contexts/SubscriptionDataProvider/use-subscription-data.ts	📈 +674 Bytes
packages/console/src/pages/TenantSettings/Subscription/DowngradeConfirmModalContent/PlanQuotaDiffCard/PlanQuotaList/DiffQuotaItem/SkuQuotaItemPhrase.tsx	📈 +96 Bytes
packages/console/src/pages/TenantSettings/components/NotEligibleSwitchPlanModalContent/index.tsx	📈 +101 Bytes
packages/console/src/types/skus.ts	📈 +5 Bytes
packages/core/package.json	0 Bytes
packages/core/src/mocks/cloud-connection.ts	📈 +29 Bytes
packages/core/src/queries/tenant-usage/types.ts	📈 +48 Bytes
packages/core/src/utils/subscription/index.ts	📈 +242 Bytes
packages/core/src/utils/subscription/types.ts	📈 +110 Bytes
pnpm-lock.yaml	📈 +217 Bytes

charIeszhao

Reviewed the quota plumbing. No standalone blockers from my side; runtime enforcement is tracked in the runner PR.

simeng-li

core changes LGTM

…add-inlinehooksenabled-subscription-quota-flag # Conflicts: # packages/schemas/src/types/logto-config/inline-hook.ts

Copilot

Pull request overview

Completes Logto Core + Console support for the Cloud subscription quota key inlineHooksEnabled, ensuring older Cloud payloads (missing the key) are treated as disabled by default and keeping the capability hidden from plan quota UI for now.

Changes:

Extend Core/Console subscription quota + usage types to include inlineHooksEnabled.
Normalize Core/Console subscription data to default inlineHooksEnabled to false when absent.
Hide inlineHooksEnabled from quota UI phrasing/diff rendering while still being represented in types and defaults.

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
pnpm-lock.yaml	Updates lockfile entries for the bumped Cloud package version.
packages/core/src/utils/subscription/types.ts	Adds `inlineHooksEnabled` to Core subscription quota/usage types and zod guards.
packages/core/src/utils/subscription/index.ts	Normalizes fetched subscription quota to default `inlineHooksEnabled: false`.
packages/core/src/queries/tenant-usage/types.ts	Adds `inlineHooksEnabled` to Core quota usage key enums (boolean quota path).
packages/core/src/mocks/cloud-connection.ts	Extends mocked quota to include `inlineHooksEnabled`.
packages/core/package.json	Bumps `@logto/cloud` dependency revision.
packages/console/src/types/skus.ts	Adjusts comment formatting for SKU type definitions.
packages/console/src/pages/TenantSettings/Subscription/DowngradeConfirmModalContent/PlanQuotaDiffCard/PlanQuotaList/DiffQuotaItem/SkuQuotaItemPhrase.tsx	Guards phrase rendering to skip hidden/non-phrase quota keys (incl. inline hooks).
packages/console/src/pages/TenantSettings/components/NotEligibleSwitchPlanModalContent/index.tsx	Excludes `inlineHooksEnabled` from “not eligible” quota rendering and adds phrase-key guarding.
packages/console/src/contexts/SubscriptionDataProvider/use-subscription-data.ts	Normalizes subscription quota/usage objects by merging defaults (covers missing `inlineHooksEnabled`).
packages/console/src/consts/tenants.ts	Adds `inlineHooksEnabled` (and required quota fields) to default SKU/quota/usage constants.
packages/console/src/consts/quota-item-phrases.ts	Excludes `inlineHooksEnabled` from quota phrase maps and adds a type guard helper.
packages/console/src/consts/plan-quotas.ts	Hides `inlineHooksEnabled` in plan quota UI diff list with an explanatory comment.
packages/console/src/cloud/types/router.ts	Extends subscription quota/usage types with `inlineHooksEnabled` and relaxes SKU quota typing for backward compatibility.
packages/console/package.json	Bumps `@logto/cloud` dependency revision.

Files not reviewed (1)

pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Merge origin/master to resolve conflicts in subscription quota types and inline hook schema. Accept master's versions for files already merged via #9077 and #9078. Add DeletionError test case for deleteInlineHook when rowCount is 0.

github-actions Bot added the feature Cool stuff label Jun 23, 2026

github-actions Bot added the size/s label Jun 23, 2026

github-actions Bot assigned wangsijie Jun 23, 2026

feat(schemas): add LOG-13689 inline hook config guards

0ea9051

wangsijie force-pushed the wangsijie-log-13689-define-logtoinlinehookkey-enum-and-zod-config-guards branch from 6881986 to 0ea9051 Compare June 23, 2026 13:56

feat(core): add LOG-13690 inline hooks quota flag

00e09a2

wangsijie force-pushed the wangsijie-log-13690-add-inlinehooksenabled-subscription-quota-flag branch from 045b209 to 00e09a2 Compare June 23, 2026 13:56

github-actions Bot added size/s and removed size/s labels Jun 23, 2026

wangsijie changed the title ~~feat(core): add LOG-13690 inline hooks quota flag~~ feat(core): add inline hooks quota flag Jun 23, 2026

github-actions Bot added size/s and removed size/s labels Jun 23, 2026

feat(console): complete inline hooks quota support

abceac5

github-actions Bot added size/l and removed size/s labels Jun 24, 2026

wangsijie changed the title ~~feat(core): add inline hooks quota flag~~ feat: add inline hooks quota support Jun 24, 2026

fix(console): keep inline hooks quota disabled by default

8a110a5

github-actions Bot added size/l and removed size/l labels Jun 24, 2026

fix(console): hide inline hooks quota item

51c93a6

github-actions Bot added size/l and removed size/l labels Jun 24, 2026

fix(console): remove hidden inline hooks phrases

7b2543b

github-actions Bot added size/m and removed size/l labels Jun 24, 2026

fix: rely on cloud inline hooks quota types

2fe4cd2

github-actions Bot removed the size/m label Jun 24, 2026

github-actions Bot added the size/s label Jun 24, 2026

wangsijie marked this pull request as ready for review June 24, 2026 06:41

wangsijie requested review from charIeszhao, gao-sun, simeng-li and xiaoyijun as code owners June 24, 2026 06:41

charIeszhao approved these changes Jun 25, 2026

View reviewed changes

simeng-li approved these changes Jun 25, 2026

View reviewed changes

Base automatically changed from wangsijie-log-13689-define-logtoinlinehookkey-enum-and-zod-config-guards to master June 25, 2026 06:34

github-actions Bot added size/m and removed size/s labels Jun 25, 2026

Merge remote-tracking branch 'origin/master' into wangsijie-log-13690-…

2c3a6e6

…add-inlinehooksenabled-subscription-quota-flag # Conflicts: # packages/schemas/src/types/logto-config/inline-hook.ts

Copilot AI review requested due to automatic review settings June 25, 2026 06:42

Copilot started reviewing on behalf of wangsijie June 25, 2026 06:43 View session

github-actions Bot added size/m and removed size/m labels Jun 25, 2026

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread packages/core/src/utils/subscription/types.ts Outdated

Comment thread packages/core/src/utils/subscription/types.ts Outdated

Comment thread packages/console/src/cloud/types/router.ts Outdated

Comment thread packages/console/src/cloud/types/router.ts Outdated

fix: address inline hooks quota feedback

6e5e585

github-actions Bot added size/m and removed size/m labels Jun 25, 2026

charIeszhao approved these changes Jun 25, 2026

View reviewed changes

wangsijie merged commit 9ff119f into master Jun 25, 2026
38 of 39 checks passed

wangsijie deleted the wangsijie-log-13690-add-inlinehooksenabled-subscription-quota-flag branch June 25, 2026 07:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add inline hooks quota support#9078

feat: add inline hooks quota support#9078
wangsijie merged 9 commits into
masterfrom
wangsijie-log-13690-add-inlinehooksenabled-subscription-quota-flag

wangsijie commented Jun 23, 2026 •

edited by cursor Bot

Loading

Uh oh!

github-actions Bot commented Jun 23, 2026 •

edited

Loading

Uh oh!

charIeszhao left a comment

Uh oh!

simeng-li left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

wangsijie commented Jun 23, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

COMPARE TO master

Uh oh!

charIeszhao left a comment

Choose a reason for hiding this comment

Uh oh!

simeng-li left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

wangsijie commented Jun 23, 2026 •

edited by cursor Bot

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

COMPARE TO `master`